frmContactEditor: Stop XAB crashing when pressing Modify/Delete

[xestiaab/.git] / source / contacteditor / frmContactEditor-Home.cpp

diff --git a/source/contacteditor/frmContactEditor-Home.cpp b/source/contacteditor/frmContactEditor-Home.cpp
index 7aa3830..e610a94 100644 (file)
--- a/source/contacteditor/frmContactEditor-Home.cpp
+++ b/source/contacteditor/frmContactEditor-Home.cpp
@@ -38,11 +38,8 @@ void frmContactEditor::AddHomeNickname( wxCommandEvent& event )
        
        // Bring up window to add nickname.
        
-       int intResult = 0;
-    
        frmContactEditorNickname *frameCENickname = new frmContactEditorNickname ( this );
        frameCENickname->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeNicknamesList);
        frameCENickname->SetupPointers(&ContactEditorData.HomeNicknamesList,
                &ContactEditorData.HomeNicknamesListAltID,
                 &ContactEditorData.HomeNicknamesListPID,
@@ -66,7 +63,7 @@ void frmContactEditor::ModifyHomeNickname( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeNicknames,
+       if (lboHomeNicknames->GetItemCount() == 0 || !GetSelectedItem(lboHomeNicknames,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -97,7 +94,7 @@ void frmContactEditor::DeleteHomeNickname( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeNicknames,
+       if (lboHomeNicknames->GetItemCount() == 0 || !GetSelectedItem(lboHomeNicknames,
                 &longSelected,
                 &intSelectedData)){
                return;
@@ -121,11 +118,8 @@ void frmContactEditor::AddHomeAddress( wxCommandEvent& event )
        
        // Bring up window to add address.      
        
-       int intResult = 0;
-    
        frmContactEditorAddress *frameCEAddress = new frmContactEditorAddress ( this );
        frameCEAddress->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeAddressList);
        frameCEAddress->SetupPointers(&ContactEditorData.HomeAddressList,
                &ContactEditorData.HomeAddressListTown,
                &ContactEditorData.HomeAddressListCounty,
@@ -157,7 +151,7 @@ void frmContactEditor::ModifyHomeAddress( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeAddresses,
+       if (lboHomeAddresses->GetItemCount() == 0 || !GetSelectedItem(lboHomeAddresses,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -196,7 +190,7 @@ void frmContactEditor::DeleteHomeAddress( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeAddresses,
+       if (lboHomeAddresses->GetItemCount() == 0 || !GetSelectedItem(lboHomeAddresses,
                 &longSelected,
                 &intSelectedData)){
                return;
@@ -221,11 +215,8 @@ void frmContactEditor::AddHomeEmail( wxCommandEvent& event )
        
        // Bring up window to add email.
        
-       int intResult = 0;
-    
        frmContactEditorEmail *frameCEEmail = new frmContactEditorEmail ( this );
        frameCEEmail->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeAddressList);
        frameCEEmail->SetupPointers(&ContactEditorData.HomeEmailList,
                 &ContactEditorData.HomeEmailListAltID,
                &ContactEditorData.HomeEmailListPID,
@@ -248,7 +239,7 @@ void frmContactEditor::ModifyHomeEmail( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeEmails,
+       if (lboHomeEmails->GetItemCount() == 0 || !GetSelectedItem(lboHomeEmails,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -279,7 +270,7 @@ void frmContactEditor::DeleteHomeEmail( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeEmails,
+       if (lboHomeEmails->GetItemCount() == 0 || !GetSelectedItem(lboHomeEmails,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -300,11 +291,8 @@ void frmContactEditor::AddHomeIM( wxCommandEvent& event )
        
        // Bring up window to add IM.
        
-       int intResult = 0;
-    
        frmContactEditorIM *frameCEIM = new frmContactEditorIM ( this );
        frameCEIM->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeIMList);
        frameCEIM->SetupPointers(&ContactEditorData.HomeIMList,
                &ContactEditorData.HomeIMListAltID,
                &ContactEditorData.HomeIMListPID,
@@ -329,7 +317,7 @@ void frmContactEditor::ModifyHomeIM( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeIM,
+       if (lboHomeIM->GetItemCount() == 0 || !GetSelectedItem(lboHomeIM,
                &longSelected,
                &intSelectedData)){
                return;
@@ -361,7 +349,7 @@ void frmContactEditor::DeleteHomeIM( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeIM,
+       if (lboHomeIM->GetItemCount() == 0 || !GetSelectedItem(lboHomeIM,
                &longSelected,
                &intSelectedData)){
                return;
@@ -382,11 +370,8 @@ void frmContactEditor::AddHomeTelephone( wxCommandEvent& event )
        
        // Bring up window to add telephone.
        
-       int intResult = 0;
-    
        frmContactEditorTelephone *frameCETel = new frmContactEditorTelephone ( this );
        frameCETel->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeTelephoneList);
        frameCETel->SetupPointers(&ContactEditorData.HomeTelephoneList,
                &ContactEditorData.HomeTelephoneListAltID,
                &ContactEditorData.HomeTelephoneListPID,
@@ -410,7 +395,7 @@ void frmContactEditor::ModifyHomeTelephone( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTelephone,
+       if (lboHomeTelephone->GetItemCount() == 0 || !GetSelectedItem(lboHomeTelephone,
                &longSelected,
                &intSelectedData)){
                return;
@@ -441,7 +426,7 @@ void frmContactEditor::DeleteHomeTelephone( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTelephone,
+       if (lboHomeTelephone->GetItemCount() == 0 || !GetSelectedItem(lboHomeTelephone,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -461,12 +446,8 @@ void frmContactEditor::AddHomeLanguage( wxCommandEvent& event )
        
        // Bring up window to add language.
        
-       int intResult = 0;
-    
        frmContactEditorLanguages *frameCELang = new frmContactEditorLanguages ( this );
        frameCELang->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeLanguageList);
-       
        frameCELang->SetupPointers(&ContactEditorData.HomeLanguageList,
                &ContactEditorData.HomeLanguageListAltID,
                &ContactEditorData.HomeLanguageListPID,
@@ -489,7 +470,7 @@ void frmContactEditor::ModifyHomeLanguage( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeLanguages,
+       if (lboHomeLanguages->GetItemCount() == 0 || !GetSelectedItem(lboHomeLanguages,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -519,7 +500,7 @@ void frmContactEditor::DeleteHomeLanguage( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeLanguages,
+       if (lboHomeLanguages->GetItemCount() == 0 || !GetSelectedItem(lboHomeLanguages,
                &longSelected,
                 &intSelectedData)){
                return;
@@ -539,11 +520,8 @@ void frmContactEditor::AddHomeTimezone( wxCommandEvent& event )
        
        // Bring up window to add timezone.
        
-       int intResult = 0;
-    
        frmContactEditorTimezones *frameCETZ = new frmContactEditorTimezones ( this );
        frameCETZ->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeTZList);
        frameCETZ->SetupPointers(&ContactEditorData.HomeTZList,
                &ContactEditorData.HomeTZListAltID,
                &ContactEditorData.HomeTZListPID,
@@ -567,7 +545,7 @@ void frmContactEditor::ModifyHomeTimezone( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTimezones,
+       if (lboHomeTimezones->GetItemCount() == 0 || !GetSelectedItem(lboHomeTimezones,
                &longSelected,
                &intSelectedData)){
                return;
@@ -598,7 +576,7 @@ void frmContactEditor::DeleteHomeTimezone( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTimezones,
+       if (lboHomeTimezones->GetItemCount() == 0 || !GetSelectedItem(lboHomeTimezones,
                &longSelected,
                &intSelectedData)){
                return;
@@ -618,11 +596,8 @@ void frmContactEditor::AddHomeGeoposition( wxCommandEvent& event )
 
        // Bring up window to add geoposition.
        
-       int intResult = 0;
-    
        frmContactEditorGeoposition *frameCEGeo = new frmContactEditorGeoposition ( this );
        frameCEGeo->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeGeographyList);
        frameCEGeo->SetupPointers(&ContactEditorData.HomeGeographyList,
                &ContactEditorData.HomeGeographyListAltID,
                &ContactEditorData.HomeGeographyListPID,
@@ -647,7 +622,7 @@ void frmContactEditor::ModifyHomeGeoposition( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeGeoposition,
+       if (lboHomeGeoposition->GetItemCount() == 0 || !GetSelectedItem(lboHomeGeoposition,
                &longSelected,
                &intSelectedData)){
                return;
@@ -679,7 +654,7 @@ void frmContactEditor::DeleteHomeGeoposition( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeGeoposition,
+       if (lboHomeGeoposition->GetItemCount() == 0 || !GetSelectedItem(lboHomeGeoposition,
                &longSelected,
                &intSelectedData)){
                return;
@@ -700,11 +675,8 @@ void frmContactEditor::AddHomeWebsite( wxCommandEvent& event )
 
        // Bring up window to add website.
        
-       int intResult = 0;
-    
        frmContactEditorWebsites *frameCEWeb = new frmContactEditorWebsites ( this );
        frameCEWeb->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeWebsiteList);
        frameCEWeb->SetupPointers(&ContactEditorData.HomeWebsiteList,
                &ContactEditorData.HomeWebsiteListAltID,
                &ContactEditorData.HomeWebsiteListPID,
@@ -728,7 +700,7 @@ void frmContactEditor::ModifyHomeWebsite( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeWebsites,
+       if (lboHomeWebsites->GetItemCount() == 0 || !GetSelectedItem(lboHomeWebsites,
                &longSelected,
                &intSelectedData)){
                return;
@@ -759,7 +731,7 @@ void frmContactEditor::DeleteHomeWebsite( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeWebsites,
+       if (lboHomeWebsites->GetItemCount() == 0 || !GetSelectedItem(lboHomeWebsites,
                &longSelected,
                &intSelectedData)){
                return;
@@ -779,11 +751,8 @@ void frmContactEditor::AddHomeTitle( wxCommandEvent& event )
        
        // Bring up window to add title.
        
-       int intResult = 0;
-    
        frmContactEditorTitles *frameCETitle = new frmContactEditorTitles ( this );
        frameCETitle->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeTitleList);
        frameCETitle->SetupPointers(&ContactEditorData.HomeTitleList,
                &ContactEditorData.HomeTitleListLanguage,
                &ContactEditorData.HomeTitleListAltID,
@@ -807,7 +776,7 @@ void frmContactEditor::ModifyHomeTitle( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTitles,
+       if (lboHomeTitles->GetItemCount() == 0 || !GetSelectedItem(lboHomeTitles,
                &longSelected,
                &intSelectedData)){
                return;
@@ -838,7 +807,7 @@ void frmContactEditor::DeleteHomeTitle( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeTitles,
+       if (lboHomeTitles->GetItemCount() == 0 || !GetSelectedItem(lboHomeTitles,
                &longSelected,
                &intSelectedData)){
                return;
@@ -858,11 +827,8 @@ void frmContactEditor::AddHomeRole( wxCommandEvent& event )
        
        // Bring up window to add role.
        
-       int intResult = 0;
-    
        frmContactEditorRoles *frameCERole = new frmContactEditorRoles ( this );
        frameCERole->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeRoleList);
        frameCERole->SetupPointers(&ContactEditorData.HomeRoleList,
                &ContactEditorData.HomeRoleListLanguage,
                &ContactEditorData.HomeRoleListAltID,
@@ -886,7 +852,7 @@ void frmContactEditor::ModifyHomeRole( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeRoles,
+       if (lboHomeRoles->GetItemCount() == 0 || !GetSelectedItem(lboHomeRoles,
                &longSelected,
                &intSelectedData)){
                return;
@@ -917,7 +883,7 @@ void frmContactEditor::DeleteHomeRole( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeRoles,
+       if (lboHomeRoles->GetItemCount() == 0 || !GetSelectedItem(lboHomeRoles,
                &longSelected,
                &intSelectedData)){
                return;
@@ -937,11 +903,8 @@ void frmContactEditor::AddHomeOrganisation( wxCommandEvent& event )
        
        // Bring up window to add organisation.
        
-       int intResult = 0;
-    
        frmContactEditorOrganisations *frameCEOrg = new frmContactEditorOrganisations ( this );
        frameCEOrg->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeOrganisationsList);
        frameCEOrg->SetupPointers(&ContactEditorData.HomeOrganisationsList,
                &ContactEditorData.HomeOrganisationsListLanguage,
                &ContactEditorData.HomeOrganisationsListSortAs,
@@ -966,7 +929,7 @@ void frmContactEditor::ModifyHomeOrganisation( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeOrganisations,
+       if (lboHomeOrganisations->GetItemCount() == 0 || !GetSelectedItem(lboHomeOrganisations,
                &longSelected,
                &intSelectedData)){
                return;
@@ -998,7 +961,7 @@ void frmContactEditor::DeleteHomeOrganisation( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeOrganisations,
+       if (lboHomeOrganisations->GetItemCount() == 0 ||!GetSelectedItem(lboHomeOrganisations,
                &longSelected,
                &intSelectedData)){
                return;
@@ -1019,11 +982,8 @@ void frmContactEditor::AddHomeNote( wxCommandEvent& event )
        
        // Bring up window to add note.
        
-       int intResult = 0;
-    
        frmContactEditorNotes *frameCENote = new frmContactEditorNotes ( this );
        frameCENote->SetEditorMode(FALSE, CE_HOME);
-       intResult = GetLastInt(&ContactEditorData.HomeNoteList);
        frameCENote->SetupPointers(&ContactEditorData.HomeNoteList,
                &ContactEditorData.HomeNoteListLanguage,
                &ContactEditorData.HomeNoteListAltID,
@@ -1047,7 +1007,7 @@ void frmContactEditor::ModifyHomeNote( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeNotes,
+       if (lboHomeNotes->GetItemCount() == 0 || !GetSelectedItem(lboHomeNotes,
                &longSelected,
                &intSelectedData)){
                return;
@@ -1078,13 +1038,13 @@ void frmContactEditor::DeleteHomeNote( wxCommandEvent& event )
        long longSelected = -1;
        int intSelectedData = 0;
     
-       if (!GetSelectedItem(lboHomeNotes,
+       if (lboHomeNotes->GetItemCount() == 0 || !GetSelectedItem(lboHomeNotes,
                &longSelected,
                &intSelectedData)){
                return;
        }
     
-       lboNotes->DeleteItem(longSelected);
+       lboHomeNotes->DeleteItem(longSelected);
     
        DeleteMapData(intSelectedData, &ContactEditorData.HomeNoteList,
                &ContactEditorData.HomeNoteListLanguage, &ContactEditorData.HomeNoteListAltID,